Run NCCL tests on the JAX-specific base container #1284
Merged
+389
−341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the green CI is because the main pipeline is not running, because it exceeds the reusable workflow limit. @Steboss agreed to take a look. |
olupton
force-pushed
the
olupton/nccl-test-base-container
branch
from
299221f to
651abfe
Compare
olupton
force-pushed
the
olupton/nccl-test-base-container
branch
from
cada0e2 to
2236693
Compare
…some matrix strategy
Steboss
reviewed
Jun 3, 2025
Steboss
reviewed
Jun 3, 2025
olupton
commented
Jun 4, 2025
olupton
commented
Jun 4, 2025
|
@olupton ready for review :) |
Steboss
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior setup pre-dated #1248, now things can be simpler.